pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
950 stars 410 forks source link

`WindowTransformAction::tryCalculate()` calculate at most 1 block result at a time #9668

Closed windtalker closed 3 days ago

windtalker commented 4 days ago

What problem does this PR solve?

Issue Number: ref #9433

Problem Summary: Before this pr, WindowTransformAction::tryCalculate() will try to calculate as many as possible results at a time. This makes the calling time of WindowTransformAction::tryCalculate() unpredictable. This pr let WindowTransformAction::tryCalculate() to calculate at most 1 block result at a time, so the calling time of WindowTransformAction::tryCalculate() won't be too long, and be more friendly for pipeline model.

What is changed and how it works?

Check List

Tests

Side effects

Documentation

Release note

None
purelind commented 4 days ago

/retest

ti-chi-bot[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [gengliqi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 3 days ago

[LGTM Timeline notifier]

Timeline:

windtalker commented 3 days ago

/retest

wuhuizuo commented 3 days ago

/retest