pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
417 stars 310 forks source link

fix typo #2312

Closed kaaaaaaang closed 10 months ago

kaaaaaaang commented 10 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
ti-chi-bot[bot] commented 10 months ago

@KanShiori: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2312#pullrequestreview-1729015076): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2b79923) 55.42% compared to head (e36eb0b) 54.65%.

:exclamation: Current head e36eb0b differs from pull request most recent head b21be81. Consider uploading reports for the commit b21be81 to get more accurate results

Files Patch % Lines
pkg/cluster/manager/display.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2312 +/- ## ========================================== - Coverage 55.42% 54.65% -0.77% ========================================== Files 325 325 Lines 34725 34725 ========================================== - Hits 19244 18977 -267 - Misses 13184 13490 +306 + Partials 2297 2258 -39 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2312/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `43.37% <0.00%> (-1.38%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.46% <0.00%> (ø)` | | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.25% <ø> (+0.02%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.48% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.38% <0.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 10 months ago

/approve

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment