pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

pdms: fix pdms grafana display #2382

Closed HuSharp closed 3 months ago

HuSharp commented 3 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

before

image

after

image

Release notes:

NONE
ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
HuSharp commented 3 months ago

@lhy1024 @rleungx PTAL, thx!

ti-chi-bot[bot] commented 3 months ago

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2382#pullrequestreview-1930639780): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.06%. Comparing base (9e11d0e) to head (cd07a2b).

:exclamation: Current head cd07a2b differs from pull request most recent head e1db0bb. Consider uploading reports for the commit e1db0bb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2382 +/- ## ======================================= Coverage 56.06% 56.06% ======================================= Files 329 329 Lines 35040 35040 ======================================= Hits 19644 19644 Misses 13058 13058 Partials 2338 2338 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2382/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.79% <100.00%> (+0.01%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.64% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.22% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline: