pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
411 stars 304 forks source link

cluster: remove duplicated tasks when prune #2435

Closed xhebox closed 2 weeks ago

xhebox commented 2 weeks ago

What problem does this PR solve?

Bug introduced by #2387.

The task builder b is reused without reseting. Thus FindTomestoneNodes will be executed twice, which is not expected.

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

Fix duplicated prompt at `tiup-cluster prune`
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from xhebox, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: