pingidentity / terraform-provider-davinci

PingOne DaVinci Terraform Provider
https://registry.terraform.io/providers/pingidentity/davinci/latest
Mozilla Public License 2.0
4 stars 1 forks source link

Re-evaluate connection dependency scenario. Consider if it should be an error. #58

Open samir-gandhi opened 1 year ago

samir-gandhi commented 1 year ago

Actual Behavior

When there are connections or subflows that are not mapped, we produce a warning

Warning: Unmapped Connection Dependency
│
│   with davinci_flow.sub_mgr_approval,
│   on dv.tf line 20, in resource "davinci_flow" "sub_mgr_approval":
│   20: resource "davinci_flow" "sub_mgr_approval" {
│
│ Flow '[Sub] Manager Approval
│ ' contains connection 'Amazon Simple Email [2022-11-11]' which is not defined in dependent connections.
│ This may lead to autogeneration of unmanaged connections or incorrect connection mapping
│
│ (and 32 more similar warnings elsewhere)

If it is not a bootstrapped connection, there is a very high chance that a subsequent apply will lead to a broken flow.

Steps to Reproduce

terraform apply a davinci_flow that points to a non-bootstrapped connection. Will see the warning, then another apply should lead to a failed flow deploy.

patrickcping commented 8 months ago

Needs re-triage to determine if there is any change to be made

samir-gandhi commented 8 months ago

It feels that we are settled on the code, but this could use help via additional documentation on: https://terraform.pingidentity.com/getting-started/davinci/