search

pinterest / PINRemoteImage

A thread safe, performant, feature rich image fetcher
Apache License 2.0
4.01k stars 511 forks source link

Xcode 12 beta 4 can't compile you #559

Closed mr-fixit closed 4 years ago

mr-fixit commented 4 years ago

FYI,

Xcode seems to have trouble figuring out that various classes that support the PINCaching protocol should be allowed as parameters of type id<PINCaching>.

mycroftcanner commented 4 years ago

Can't compile either...

Incompatible block pointer types sending 'void (^)(PINCache _Nonnull __strong, NSString _Nonnull strong, id _Nullable strong)' to parameter of type 'PINCacheObjectBlock _Nullable' (aka 'void (^)(id _Nonnull strong, NSString * _Nonnull strong, id _Nullable __strong)')

mycroftcanner commented 4 years ago

@zacwest @garrettmoon @mRs- @Adlai-Holler Any chance you could commit a fix for PINRemoteImage please?

https://github.com/pinterest/PINCache/pull/273

zboralski commented 4 years ago

Temporary Workaround

ENV['COCOAPODS_DISABLE_STATS'] = "true"
use_frameworks!

target 'XX' do
    platform :ios, '13.6'
    pod 'Texture', :git => 'https://github.com/TextureGroup/Texture', :branch => 'master'
    pod 'PINRemoteImage', :git => 'https://github.com/zacwest/PINRemoteImage', :branch => 'fix-xcode-12.0b4'
    pod 'PINCache', :git => 'https://github.com/pinterest/PINCache', :branch => 'master'
end
Destriarch commented 4 years ago

Still getting this issue in PINRemoteImage 3.0.3