search

pinterest / PINRemoteImage

A thread safe, performant, feature rich image fetcher
Apache License 2.0
4.01k stars 511 forks source link

Support Building from Xcode 15 #641

Closed andyfinnell closed 6 months ago

andyfinnell commented 6 months ago

Summary

Currently, PINRemoteImage does not build with recent build tools. We should fix that, plus update all the dependencies.

This bumps min versions of iOS and tvOS up to 14.0, and macOS to 11.0. This allows us to drop the libwebp dependency, which is not currently building with recent tools either, and instead use the system provided decoder. This does mean tvOS loses support for WebP as tvOS doesn't have a system decoder.

Also, clean up the headers. Cocoapods was including way too much as public headers, and we were using double quotes instead of angle brackets for them.

Test plan

Make sure everything builds & unit tests pass. Also, update all the examples and ensure they work.

andyfinnell commented 6 months ago

cc @tstump-phunware

jaichaudhry commented 6 months ago

Is this planned to be in any release soon?

andyfinnell commented 6 months ago

Hi @jaichaudhry . Yes, this got released with 3.0.4.