pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift
Apache License 2.0
308 stars 37 forks source link

using Logger instead of Lager #17

Closed laozhp closed 8 years ago

laozhp commented 8 years ago

Using Elixir.Logger instead of erlang lager, and remove the dependancy of exlager.

scohen commented 8 years ago

Lager is a much better logging library than Elixir's Logger, it protects you from process overload, and unlike Logger, can log to files without having the developer write a backend. These errors are useful to see in production, and you won't be able to see them if you can't log to a file.

I think it's reasonable to have it included as a dependency here.