pion / webrtc

Pure Go implementation of the WebRTC API
https://pion.ly
MIT License
13.52k stars 1.64k forks source link

Release Pion WebRTC v3.2.0 #2233

Closed Sean-Der closed 6 months ago

Sean-Der commented 2 years ago

It has been a long time since we have made a minor release (September). I think now is a good time to make another one! This minor release will be no different then patch releases for users. I just see this as an opportunity to apply some polish to Pion. When we are done is also a good time to announce all the great work everyone has been doing.

Here are the things I would like to do before tagging a v3.2.0

Audit and Close issues I would like to take this chance to close out as many issues as possible. Or at least audit all the issues that would require breaking changes. I will start making that list here today.

Bring Congestion Control to a Usable State I don't know how to define this. Maybe we are already done? @mengelbart @kevmo314 what do you think? More examples, features or bug fixing needed?

Write Release Notes What are the high level features that everyone is excited about? Are they in a good state for people to start using?

What else What else do people think would make a compelling release? @davidzhao @kevmo314 @adriancable @wdouglass @jech @at-wat @boushley @enobufs @mengelbart @cnderrauber @jselbie @iamcalledrob @boks1971 @AndyEsser. If I missed someone please add them! These are people who have been active on GitHub/Slack

Sean-Der commented 2 years ago

@adityaa30

kevmo314 commented 2 years ago

Does the GCC congestion controller support RFC8888? I think it would be good to have that in so we standardize on a congestion control format. It's not so easy to change later if we want to maintain backwards compatibility.

mengelbart commented 2 years ago

Congestion Control currently does not work with RFC 8888. We have https://github.com/pion/interceptor/pull/112 for adding an RFC 8888 interceptor to generate feedback, but that currently does not perform as good as another implementation and I would like to improve that before merging that. Once that is done, we can add support to the congestion controller as well. I agree that it would be nice to have that done before the release, but I am not sure if it would really be that hard to add support for RFC 8888 later since the congestion controller can just continue to work with whatever feedback it receives.

I would also like to finish some more tests for BWE, so we can actually point to some plots that show how it behaves in different network conditions. I think I have done most of what we need for that before, but I have to put it all together in one repository. I already started https://github.com/pion/bwe-test a while ago for that, just didn't get to add all tests and visualizations yet.

jech commented 2 years ago

I think that pion/webrtc#1803 is fairly important, it regularly appears in my race detector logs.

What about https://github.com/pion/webrtc/issues/1675? This causes real issues with non-browser clients.

I'm also taking the opportunity to point at my todo list: https://github.com/jech/galene/issues/14. There's a lot of overlap with Sean's, fortunately.

mohammadne commented 2 years ago

Hi, I would like to know pion/webrtc#1998 can be merged for this release?

Sean-Der commented 6 months ago

Pion WebRTC 3.2.0 was released. Currently working on v4