codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 79.00%. Comparing base (
9d6c27f) to head (aa0d9ab). Report is 1 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| sdp.go | 50.00% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2926 +/- ## ========================================== - Coverage 79.01% 79.00% -0.02% ========================================== Files 89 89 Lines 8564 8568 +4 ========================================== + Hits 6767 6769 +2 - Misses 1310 1311 +1 - Partials 487 488 +1 ``` | [Flag](https://app.codecov.io/gh/pion/webrtc/pull/2926/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/webrtc/pull/2926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `80.55% <50.00%> (-0.02%)` | :arrow_down: | | [wasm](https://app.codecov.io/gh/pion/webrtc/pull/2926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `64.47% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pion extracts them from ssrc-group line so this didn't failed Pion<->Pion. Chrome/FireFox uses the dedicated a=ssrc lines and our Offer/Answer would break negotation
Fixes #2922