pion / webrtc

Pure Go implementation of the WebRTC API
https://pion.ly
MIT License
13.9k stars 1.66k forks source link

Fix race when closing ICE Transport #2940

Closed Sean-Der closed 1 month ago

Sean-Der commented 1 month ago

Struct member is copied to stack already, stop just incorrectly was referencing the member.

Found in CI

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.70%. Comparing base (ae89317) to head (85bd5d2). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2940 +/- ## ========================================== + Coverage 77.68% 77.70% +0.02% ========================================== Files 89 89 Lines 10462 10462 ========================================== + Hits 8127 8130 +3 + Misses 1845 1844 -1 + Partials 490 488 -2 ``` | [Flag](https://app.codecov.io/gh/pion/webrtc/pull/2940/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/webrtc/pull/2940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.27% <100.00%> (+0.03%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/webrtc/pull/2940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `63.56% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.