pion / webrtc

Pure Go implementation of the WebRTC API
https://pion.ly
MIT License
13.9k stars 1.66k forks source link

Fix race with icetransport mux #2953

Closed sukunrt closed 1 week ago

sukunrt commented 1 week ago

We need to use to value that was read when the lock was held.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.71%. Comparing base (e6a86e7) to head (b327431). Report is 27 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2953 +/- ## ========================================== - Coverage 78.94% 77.71% -1.23% ========================================== Files 89 89 Lines 8488 10515 +2027 ========================================== + Hits 6701 8172 +1471 - Misses 1299 1851 +552 - Partials 488 492 +4 ``` | [Flag](https://app.codecov.io/gh/pion/webrtc/pull/2953/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/webrtc/pull/2953/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.27% <ø> (-1.23%)` | :arrow_down: | | [wasm](https://app.codecov.io/gh/pion/webrtc/pull/2953/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `63.56% <ø> (-1.55%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: