piotrwitek / react-redux-typescript-guide

The complete guide to static typing in "React & Redux" apps using TypeScript
https://piotrwitek.github.io/react-redux-typescript-guide/
MIT License
13.35k stars 1.09k forks source link

[feat lang]: Chinese readme (half-way) #199

Closed seognil closed 2 years ago

seognil commented 4 years ago

Description

Hi, there,

I wrote a Chinese Version of the readme to let more people saw your great work 🎉
(by add a README_SOURCE-zh.md)
But I'm not sure the doctoc, so other files are untouched

Is there any chance for us to finish the process and merge it?

If okay, I would find some language reviewers.

Changed

Checklist

piotrwitek commented 4 years ago

Hey @seognil. Oh man, that's really awesome thanks for your incredible work. I'm really excited about it and I would love to add to the repository.

For now, let's try to merge it ASAP, I'll try to review it right now.

For the near future, I'll think about some more generic way using internationalization techniques to make it easier to improve and maintain the translations.

seognil commented 4 years ago

toc seems fixed

I'm also working on scripts for i18n as you mention before

check this https://github.com/seognil-contributor/react-redux-typescript-guide/blob/feat-generate-readme/doctoc.js

piotrwitek commented 4 years ago

That looks great, although I was thinking about something better. We could use mdx and some internationalization library, then extract all the text nodes that needs translations into a separate json file. It should be easier to keep at sync when the guide is extended with a new content and also translating to other languages.

Then we would publish it on the Github pages as a website where you can change languages with a switch. Although don't expect it soon as it would take a lot of time to do.

seognil commented 4 years ago

wow, you are right, i18n are some serious staff now! really need to lookup in long run