pipe-cd / pipecd

The One CD for All {applications, platforms, operations}
https://pipecd.dev
Apache License 2.0
1.1k stars 154 forks source link

Support `commitMatcher` for app kinds other than K8sApp #4966

Closed t-kikuc closed 1 month ago

t-kikuc commented 5 months ago

What would you like to be added:

Support commitMatcher for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.

Why is this needed:

Currently, commitMatcher is only supported for K8sApp as below:

[IMO] Such logic should be placed in the common planner.go, not platform-specific files.

t-kikuc commented 5 months ago

I found the docs is correct. commitMatcher exists only in KubernetesApp

image image
ffjlabo commented 1 month ago

Support it on the pipedv1.