Closed t-kikuc closed 1 month ago
What would you like to be added:
Support commitMatcher for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.
commitMatcher
Why is this needed:
Currently, commitMatcher is only supported for K8sApp as below:
K8sApp: https://github.com/pipe-cd/pipecd/blob/812907842c79b6c26f48fc56cf533d9a47cc24a2/pkg/app/piped/planner/kubernetes/kubernetes.go#L166-L196
ECSApp: does not have such logic. (CloudRun, Lambda, Terraform too) https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/ecs/ecs.go
[IMO] Such logic should be placed in the common planner.go, not platform-specific files.
I found the docs is correct. commitMatcher exists only in KubernetesApp
KubernetesApp
Support it on the pipedv1.
What would you like to be added:
Support
commitMatcher
for CloudRunApp, TerraformApp, ECSApp, and LambdaApp.Why is this needed:
Currently,
commitMatcher
is only supported for K8sApp as below:K8sApp: https://github.com/pipe-cd/pipecd/blob/812907842c79b6c26f48fc56cf533d9a47cc24a2/pkg/app/piped/planner/kubernetes/kubernetes.go#L166-L196
ECSApp: does not have such logic. (CloudRun, Lambda, Terraform too) https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/ecs/ecs.go
[IMO] Such logic should be placed in the common planner.go, not platform-specific files.