pipelka / vdr-plugin-xvdr

DISCONTINUED - XVDR Plugin for VDR
GNU General Public License v2.0
43 stars 21 forks source link

VDR shows recordings double #92

Closed seahawk1986 closed 11 years ago

seahawk1986 commented 11 years ago

Hello, if the xvdr-plugin is enabled vdr counts recordings in subfolders two times and the live-plugin shows them doubled until there was another update of the recording list (e.g. by touching .update). I have encountered this effect using the latest vdr plugin version from git with VDR 1.7.27, 1.7.33 and 1.7.36

Any Idea how and why this happens?

pipelka commented 11 years ago

@OleSvensson @seahawk1986

I currently have no clue why this should happen. It doesn't happen for me (with vdr-adminam).

A wild guess. Can you please check if this patch helps:

diff --git a/src/xvdr/xvdrclient.c b/src/xvdr/xvdrclient.c
index 7f4c46d..7ae64c0 100644
--- a/src/xvdr/xvdrclient.c
+++ b/src/xvdr/xvdrclient.c
@@ -1515,7 +1515,6 @@ bool cXVDRClient::processRECORDINGS_GetDiskSpace() /* OPCODE 100 */

 bool cXVDRClient::processRECORDINGS_GetCount() /* OPCODE 101 */
 {
-  Recordings.Load();
   m_resp->put_U32(Recordings.Count());

   return true;

Please also try to rename a recording.

pipelka commented 11 years ago

Another one to apply:

diff --git a/src/recordings/recordingscache.c b/src/recordings/recordingscache.c
index 9a5f70b..e27a361 100644
--- a/src/recordings/recordingscache.c
+++ b/src/recordings/recordingscache.c
@@ -31,7 +31,6 @@
 cRecordingsCache::cRecordingsCache() : m_changed(false)
 {
   // initialize cache
-  Recordings.Load();
   for (cRecording *recording = Recordings.First(); recording; recording = Recordings.Next(recording))
     Register(recording);
 }
seahawk1986 commented 11 years ago

It seems it works on VDR 1.7.38 on my Arch Linux system (but I do have only a few recordings on it) - I will test it with VDR 1.7.27 on my yaVDR 0.5, too. @OleSvensson: which yaVDR vdr PPA do you use (stable, testing, unstable)? Until I have tested it (and copied it to the other pvr-PPAs) you can build it yourself (if you don't want to apply the patches yourself):

sudo apt-get update
sudo apt-get build-dep vdr-plugin-xvdr
dget -xu --build https://launchpad.net/~seahawk1986-hotmail/+archive/xvdr-frodo-unstable-vdr/+files/vdr-plugin-xvdr_0.9.8.git20130217-1yavdr-0~precise.dsc
dpkg -i vdr-plugin-xvdr_0.9.8.git20130217-1yavdr-0~precise_amd64.deb
seahawk1986 commented 11 years ago

I did several restarts with VDR 1.7.27 and did not encounter any duplicate entries. The folder count in vdr's recording menu are also correct. Renaming recordings using the live-plugin works fine. I will update my PVR-PPAs and ask other users if this solves their problem, too (http://www.vdr-portal.de/board60-linux/board14-betriebssystem/board96-yavdr/116395-aufnahmen-weden-doppelt-angezeigt/) Thank you very much.

pipelka commented 11 years ago

Great. I assume you applied both patches ?

seahawk1986 commented 11 years ago

Yes I applied both of them.

OleSvensson commented 11 years ago

Same here. After applying both patches all recordings are shown correctly.

@seahawk1986: I'm using yaVDR 0.5 stable repositories in combination with your xbmc-ppa and tested those patches against a manual build beforehand. Both installations work well.

Cheers, Ole