search

pipelka / xbmc-addon-xvdr

DISCONTINUED - Standalone XVDR addon for XBMC
GNU General Public License v2.0
43 stars 16 forks source link

Forward-port API 1.7.0 additions and stubs #96

Closed herrnst closed 11 years ago

herrnst commented 11 years ago

These changes sort-of lift xbmc-addon-xvdr's compatibility to recent API 1.7.0 updates.

Please note: While this PR makes XBMC-master initialise and load the addon, and connects to the XVDR server, this will - for some reason I don't understand, maybe you have an idea - crash the VDR (1.7.33) server:

Mar 10 17:00:30 barias kernel: [19077.554849] VDR XVDR Server[23494]: segfault at 8 ip 00007f6c80908101 sp 00007f6c737fdae8 error 4 in libc-2.15.so[7f6c8087f000+1b5000]
Mar 10 17:00:30 barias runvdr: restarting VDR

According to the backtrace (see http://pastebin.com/jqXv4E3M - "bt full") it crashes in src/xvdr/xvdrclient.c in processTIMER_Add() in the call to cTimer::Parse(buffer). I guess the format (or order) of some options retrieved at the top of that method have changed somehow, so the string passed to cTimer::Parse() is invalid. But this needs to be investigated further.

So while this PR doesn't provide a fully working solution ATM (and maybe looks like some half-assed attempt to update things ;) ), this PR might still act as a starting point for something. At least the client addon builds without errors :)

pipelka commented 11 years ago

Sorry Daniel, I have to close this. I wrote a working version on my own: 67cada1fc0216ad090ef79f2818c4e31a4dfa1c8

herrnst commented 11 years ago

No problem, looking at your commit, I even missed many things (so the term "half-assed try" applies very well it seems). Will happily test your changes this evening (and I have a feeling it will work even without touching the server side at all...)

herrnst commented 11 years ago

Just tested and found working without further adjustment to the server - thanks for taking on this! (really should leave such things to the pro's - no promises here, though ;)) )