pippinsplugins / bbPress-Private-replies

A simple bbPress extension for allowing users to mark their replies as private
13 stars 19 forks source link

Provide option to override the default `do_not_reply` email address #19

Closed sudar closed 8 years ago

sudar commented 10 years ago

In the recent version of bbPress, the way subscription emails are generated is changed and I see that you have made this commit to fix it. But unfortunately there are couple of problems in the way the default do_not_reply is generated. They are documented in this bbpress forum post and blog post

This ticket in bbPress fixes most of the issues with the default do_not_reply email address and also adds some filters so that people can change them if needed. The do_not_reply email address generation logic should be changed to the one that is used in the ticket so that it fixes the issues with it.

solhuebner commented 10 years ago

Any news on this one?

pippinsplugins commented 10 years ago

Sorry, I haven't had time to work on this yet.

solhuebner commented 10 years ago

Sorry for all the questions but this is just a really cool plugin ☺

pippinsplugins commented 8 years ago

We now use bbPress's helper function for getting the no reply address and it's passed through a filter so it can be changed for private replies.

/**
 * Retrieves the no reply address.
 *
 * @since 1.3.3
 *
 * @return string
 */
public function get_no_reply() {
    return apply_filters( 'bbp_private_replies_no_reply_address', bbp_get_do_not_reply_address() );
}