piprate / json-gold

A JSON-LD processor for Go
Apache License 2.0
259 stars 30 forks source link

Check JSON Literal support against official test suite #41

Closed kazarena closed 3 years ago

kazarena commented 3 years ago

Re: #35.

@kdimak, I had to fix the N-Quad comparison logic before testing the new JSON Canonicalisation against the official test suite in ld/testdata/toRdf-manifest.jsonld. I realised some tests were passing due to an issue with the quad comparison, while in fact they failed.

For your information, out of 23 tests for JSON literals (toRDF algorithm), the following tests are still failing:

tjs07

tjs08

tjs14

tjs15

tjs16

tjs17

tjs18

tjs21

tjs22

tjs23

(marked as to be skipped)

It's still better coverage than we had before, so thank you for the PR. Some of these tests are pretty easy to fix. I'll do it when I have time.

@troyronda @rolsonquadras