piprate / json-gold

A JSON-LD processor for Go
Apache License 2.0
259 stars 30 forks source link

should return serializer error #67

Closed suutaku closed 1 year ago

suutaku commented 1 year ago

Summary

uncatched serializer error will course crash

Basic example

Frame with invalid type of schema. for example, with @context https://w3id.org/citizenship/v1 , change PermanentResidentCard to PermanentResidentCar, program will crash

Motivation

service use jsonld should not crash

codecov[bot] commented 1 year ago

Codecov Report

Base: 79.93% // Head: 79.88% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (7f5119b) compared to base (c70834a). Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #67 +/- ## ========================================== - Coverage 79.93% 79.88% -0.05% ========================================== Files 20 20 Lines 6179 6180 +1 ========================================== - Hits 4939 4937 -2 - Misses 958 960 +2 - Partials 282 283 +1 ``` | [Impacted Files](https://codecov.io/gh/piprate/json-gold/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=piprate) | Coverage Δ | | |---|---|---| | [ld/processor.go](https://codecov.io/gh/piprate/json-gold/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=piprate#diff-bGQvcHJvY2Vzc29yLmdv) | `66.08% <25.00%> (-0.67%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=piprate). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=piprate)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kazarena commented 1 year ago

Thank you, looks like an obvious omission.