search

pishoyg / coptic

This is a project that aims to make the Coptic language more learnable.
https://remnqymi.com/
GNU General Public License v3.0
10 stars 0 forks source link

[Crum/Images/Helper] Miscellaneous Improvements #261

Closed pishoyg closed 1 month ago

pishoyg commented 2 months ago
  1. Guard against accidental use of gstatic.com.
  2. Report an error when retrieving an image fails.
  3. Group error handling to one location. Wrap most logic in a single try-catch block.
  4. Don't open images from noun!
pishoyg commented 2 months ago

~TODO: You should fix the height, not the width!~

Edit: Nah! Keep it as is!

pishoyg commented 1 month ago

NOTE: A few improvements were made in #22.

pishoyg commented 1 month ago

TODO:

  1. Add https://uxwing.com/ as an icon source.
  2. Guard against accidental use of gstatic.com.
  3. Group error handling to one location. Wrap most logic in a single try-catch block.
  4. Report an error when retrieving an image fails.

Obsolete:

  1. Don't open images from noun! (It's no longer used since 00b44d66a0e5d40f60b3a72a3d9fddfc3867e422, due to #263).
pishoyg commented 1 month ago

Status:

DONE:

  1. Add https://uxwing.com/ as an icon source.

Already done:

  1. Report an error when retrieving an image fails.

TODO:

  1. Guard against accidental use of gstatic.com.
  2. Group error handling to one location. Wrap most logic in a single try-catch block.
pishoyg commented 1 month ago

TODO: Introduce a new command - clear to delete all pictures belonging to a given key.