piskvorky / gensim

Topic Modelling for Humans

https://radimrehurek.com/gensim

GNU Lesser General Public License v2.1

15.7k stars 4.38k forks source link

Upgrade to NumPy 2.1 #3560

Open MaximilianHess opened 2 months ago

MaximilianHess commented 2 months ago

Problem description

We're planning to use NumPy 2.1 in our project due to its performance improvements. However, Gensim currently depends on NumPy 1.26.4. Are there any plans to update Gensim's dependencies to support NumPy 2.1? Currently, attempting to use Gensim with NumPy 2.1 results in a failure.

mpenkov commented 2 months ago

Closing as duplicate of https://github.com/piskvorky/gensim/pull/3535

gojomo commented 2 months ago

3535 was a quickie investigational PR into the effort required for Numpy 2.x support – & it might not get much attention. It's probably not the right place to discuss project plans, if any, for Numpy 2.x support - an issue which might spawn many other PRs, bug reports, &

frequent-questions.

mpenkov commented 2 months ago

OK, let's make this the discussion place instead of #3535.

hechth commented 2 weeks ago

@mpenkov @YoungMind1 and @piskvorky I've had a quick look at the numpy update and building the package seems fine and only few tests are broken. I'll give it a go tomorrow and see if I can fix the tests.

knevan commented 2 weeks ago

I'm also having trouble with my project because it uses spacy which blis and thinc use numpy>2.0 while gensim is still with numpy 1.26.4.