Closed rdyro closed 1 year ago
Can you please fix the flake8 errors in the code as well?
https://github.com/RaRe-Technologies/sqlitedict/actions/runs/3303841568/jobs/5456104420
I just fixed the flake8 errors.
Would documenting this optional key encoding in the README be a good idea? I added a commit for that.
Could we merge this into master?
This PR adds attempts to add a useful optional feature, while introducing minimum extra complexity and not affecting performance.
Yes, of course. I've merged your work. Thank you!
This pull requests adds the optional behavior of encoding keys.
The justification: support for hashable, but not
str
(orint
) keys, e.g.tuple
as a key.The changes include:
encode_key
anddecode_key
methodencode_key
anddecode_key
which are base64 encoding of pickle dump of keyPotential problems: