search

piskvorky / sqlitedict

Persistent dict, backed by sqlite3 and pickle, multithread-safe.
Apache License 2.0
1.16k stars 130 forks source link

DeprecationWarning: setDaemon() is deprecated #162

Closed Justintime50 closed 1 year ago

Justintime50 commented 1 year ago

After running my test suite, I receive the following error stating that functionality in this lib is deprecated:

/Users/jhammond/git/personal/harvey/venv/lib/python3.10/site-packages/sqlitedict.py:381: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
    self.setDaemon(True)  # python2.5-compatible

It looks like based on the comment next to it it's there to retain Python 2.5 compatibility. As Python 3.10 and 3.11 become more prevalent, it may be needful to adjust this line to instead be forwards compatible.

Justintime50 commented 1 year ago

Looks like this was patched via https://github.com/RaRe-Technologies/sqlitedict/pull/157