pistocop / pistoBot

Create an AI that chats like you
https://pistocop.github.io/pistoBot-website/
GNU General Public License v3.0
140 stars 22 forks source link

Suggest to loosen the dependency on knockknock #7

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Hi, your project pistoBot(commit id: ef50c5127c7371bd5c6c9ae68ce9cecb65a916f1) requires "knockknock==0.1.8.1" in its dependency. After analyzing the source code, we found that the following versions of knockknock can also be suitable, i.e., knockknock 0.1.3, 0.1.4, 0.1.5, 0.1.6, 0.1.7, 0.1.8, since all functions that you directly (1 APIs: knockknock.telegram_sender.telegram_sender) or indirectly (propagate to 0 knockknock's internal APIs and 5 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on knockknock from "knockknock==0.1.8.1" to "knockknock>=0.1.3,<=0.1.8.1". This will improve the applicability of pistoBot and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on knockknock?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?