search

pitermarx / NCalc2

Clone of NCalc, ported to netstandard2.0
MIT License
11 stars 3 forks source link

.NET 4.6 version #3

Closed ellern closed 9 years ago

ellern commented 9 years ago

Any chance you can update this to use the latest .NET 4.6?

ellern commented 9 years ago

I have tried but the ExpressionMixCachePerformanceTest jumps from <10ms to >500ms.

I don't know if that's a problem with ANTLR or the lexer or parser I generated.

pitermarx commented 9 years ago

Why do you need to update? Is it not possible to reference this from a .net 4.6 project?

ellern commented 9 years ago

Probably not, it's actually because I need to have a task based EvaluateFunctionHandler and EvaluateParameterHandler and I figured it would be best to start out with the latest antlr version.

Btw. performance seems to be on par after I removed the TRACE constant from Release builds.

pitermarx commented 9 years ago

Why did release builds have TRACE defined? Please remove it and create pull request. The Task class exists on .net 4. Is it really necessary to update to 4.6 to do your custom Evaluates?

ellern commented 9 years ago

The trace constant was turned on by mistake. Some of my Function- and Parameter methods needs to consume async methods.

pitermarx commented 9 years ago

I dont think i will up the .net framework just to have an async Handler. Feel free to fork this though. If i find the use case really relevant i might consider it