search

pivotal / LicenseFinder

Find licenses for your project's dependencies.
MIT License
1.72k stars 339 forks source link

CSV no longer part of the stdlib #1015

Closed benlangfeld closed 8 months ago

benlangfeld commented 8 months ago

On Ruby 3.3 the following warning is emitted:

/usr/local/bundle/ruby/3.3.0/gems/license_finder-7.1.0/lib/license_finder/package_managers/sbt.rb:3: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of license_finder-7.1.0 to add csv into its gemspec.

As of Ruby 3.4 license_finder would cease to work without this explicit dependency.

See also https://github.com/pivotal/LicenseFinder/pull/1014

cf-gitbot commented 8 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

xtreme-shane-lattanzio commented 8 months ago

@benlangfeld I added the tests for 3.3.x and all seems to be green so I do not think that this is needed

benlangfeld commented 8 months ago

@benlangfeld I added the tests for 3.3.x and all seems to be green so I do not think that this is needed

Tests pass but warnings are emitted. Tests will only fail on 3.4.0.

xtreme-shane-lattanzio commented 8 months ago

@benlangfeld I see, Would you be able to add version constraints to this and then I'll get it merged? Thanks!!