pkf1994 / pengithub-vue

0 stars 1 forks source link

SSR: textarea domProps keeps falsy values #6

Open czf1998 opened 4 years ago

czf1998 commented 4 years ago

Version

2.6.10

Reproduction link

https://codesandbox.io/s/codesandbox-nuxt-vdcv8

Steps to reproduce

View page source

What is expected?

<textarea id="input-62" rows="5"></textarea>

What is actually happening?

<textarea id="input-62" rows="5">null</textarea>


Similar to #9231

Repro in vue/test/ssr/ssr-string.spec.js:

 it('falsy domProps value', done => {
    renderVmWithOptions({
      render (h) {
        return h('div', [
          h('textarea', {
            domProps: {
              value: null
            }
          })
        ])
      }
    }, result => {
      expect(result).toContain(
        '<div data-server-rendered="true"><textarea></textarea></div>'
      )
      done()
    })
  })

Relevant vuetify code: https://github.com/vuetifyjs/vuetify/blob/243a7c34a1c58dff3753ad35dded13ba5002c8eb/packages/vuetify/src/components/VTextarea/VTextarea.ts#L86-L92 https://github.com/vuetifyjs/vuetify/blob/243a7c34a1c58dff3753ad35dded13ba5002c8eb/packages/vuetify/src/components/VTextField/VTextField.ts#L357-L361

czf1998 commented 4 years ago

pkf1994/pengithub-vue#4 pkf1994/pengithub-vue#3