pkgjs / parseargs

Polyfill of `util.parseArgs()`

Apache License 2.0

121 stars 9 forks source link

linter: our linter is missing some rules from the Node.js codebase #90

Open bcoe opened 2 years ago

bcoe commented 2 years ago

requirement of using errors.js, vs., new Error.
expectation of object vs., array destructuring.

Refs: https://github.com/pkgjs/parseargs/pull/89

shadowspawn commented 2 years ago

Our current dependency is:

    "eslint-plugin-node-core": "iansu/eslint-plugin-node-core",

shadowspawn commented 2 years ago

eslint-plugin-nodejs-internal had been created.

(node-core-test is looking at using same linter and rules too: https://github.com/nodejs/node-core-test/issues/22 )

iansu commented 2 years ago

As far as I know nodejs/eslint-plugin-nodejs-internal is an exact copy of iansu/eslint-plugin-node-core. I just double checked and that repo still only has the one original commit. I can look at making a PR to update the nodejs version with whatever is in core (if there are changes) and then make a PR switching parseargs over to that.