search

pkiraly / qa-catalogue

QA catalogue – a metadata quality assessment tool for library catalogue records (MARC, PICA)
GNU General Public License v3.0
82 stars 17 forks source link

Update of PICA K10plus Avram scheme breaks build #475

Open nichtich opened 6 months ago

nichtich commented 6 months ago

I tried to update the PICA K10plus Avram schema at https://github.com/pkiraly/qa-catalogue/tree/avram-k10plus-update

The Avram schema looks good but Maven build fails because of failing tests.

An update of a valid Avram Schema should never make the build fail, otherwise we cannot deploy automatic updates.

I think the reason is in tests relying in a specific version of the Avram schema. If test do so, they should only use schema versions located in src/test/ directories.

Maybe the Avram schema be should be moved from src/main/ to be only loaded at run-time, not at compile time.

pkiraly commented 6 months ago

It is also worth considering introducing versioning of the schema.

nichtich commented 6 months ago

I'll try to not update PICA K10plus Avram schema but use configuration parameter to provide updated version at runtime.