search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
299 stars 444 forks source link

[OJS 3_4] submission Url not role dependant in discussion notification #10415

Open forgive38 opened 2 weeks ago

forgive38 commented 2 weeks ago

If a participant of a discussion has the author role, he should receive the url for authors, but he receives the url for "editors". same case for discussions with reviewers.

I've tried to solve the problem by adding a param to Mailable, but I'm stuck. I did a PR with a beginning but I'm not sure it's the right way to go...

I wonder if the simplest way wouldn't be to put a redirect in dispatcher for the main url “workflow/access/$submissionId”, depending on the current user's role: if he's only an author on the submission, we'll redirect him to authorDashboard and if he's only a reviewer, we'll redirect him to reviewer dashboard.

what do you think?

Thank you

asmecher commented 2 weeks ago

@Vitaliy-1, could you look at this (and the associated PR)? Thanks, @forgive38!