search

pkulchenko / MobDebug

Remote debugger for Lua.
Other
889 stars 192 forks source link

Fix. Partial recv in debug loop #69

Open moteus opened 2 years ago

moteus commented 2 years ago

Is there any guidlines for code style for this module? E.g. is it safe to decompose debug_loop function? Righ now I working on addition a new protocol and it will be much easily to do this if split protocol from implementation.

pkulchenko commented 2 years ago

Interesting; I don't think there are any strict guidelines, but it may be worthwhile to implement some basic protocol elements you want to add first (with the mobdebug changes you'd need) and then review/discuss those.

moteus commented 2 years ago

I working on VSCode extension for ModDebug library. My main concerns is it safe to move lines like capture_vars(stack-1, coro_debugee) to a separate function.

pkulchenko commented 2 years ago

Yes, it may be possible to move it, but I suspect that stack-1 index will have to be adjusted accordingly for the depth added by the additional function calls.