search

plabayo / rama

modular service framework to move and transform network packets
https://ramaproxy.org
Apache License 2.0
187 stars 21 forks source link

add "Deny All" Dns Resolver #344

Closed parkma99 closed 4 weeks ago

parkma99 commented 1 month ago

implement #329

parkma99 commented 4 weeks ago

Thanks, now all tests is passed, I find git is little confusing😊

GlenDC commented 4 weeks ago

Thanks, now all tests is passed, I find git is little confusing😊

Yeah it is not something that one can just use without learning the nuances sadly. Should you be interested I find https://git-scm.com/book/en/v2 still the leading resource that is worth reading at least once in your career. Certainly most chapters, but not all.

Thanks for this contribution by the way, greatly appreciated. Going to give it a last review, if it's okay and also all CI checks pass, I'll merge it in. Otherwise I'll come back with more feedback.

Feel free to pick up another one, give feedback in any other way, or just leave it as-is. Either way, have a nice life ahead of you and I wish you all the best!