plabayo / rama

modular service framework to move and transform network packets
https://ramaproxy.org
Apache License 2.0
187 stars 21 forks source link

Feat 330/allow anonymous trait implementation #351

Closed calebbourg closed 2 weeks ago

GlenDC commented 2 weeks ago

Problem with this approach is that you are now adding it to multiple parts of the stack. E.g. you have it in ProxyAuth but also in the credentials themselves. It also doesn't make really sense to add it to a credential as what's the point of a creating that credential in first place. And finally you implement it from stuff like Bearer<()> but nothing else.

I do like the initiative, but I believe it's the wrong approach, regardless of the flaws that would need to be fixed if you would go for it. Still, nice attempt though, it shows that you start to feel more comfortable with the code base and that is nice to see. Good job regardless.