search

plainblack / Lacuna-Server-Open

The open source Lacuna Server repository.
36 stars 29 forks source link

Send Spies #277

Open lemming552 opened 10 years ago

lemming552 commented 10 years ago

The function prepare_send_spies chooses the first 100 spies on a planet, but if the first 100 are not available no spies can be sent. Since the spies are chosen in alphabetical order, a work around for the user is to have spies unavailable (such as training) to be named so they don't get picked...

No simple fix since the spies have to be checked if available, but we don't want to spend too much time doing tests if all spies from an empire happen to be on one planet... Can probably grab a link to all, test until 100 qualify instead of current method?

Imzogelmo commented 9 years ago

Of course fetch has the same issue, and it's all the worse because until the fetching ship arrives, the same 100 spies are going to appear in the list (unless you do multiple renames); and while the spies await the fetching ship, they could be "fetched" by another ship, which will subsequently arrive and have no passengers.

lemming552 commented 9 years ago

This is actually being looked at, and yes, the whole fetching the same spies multiple times is something being looked at.