planetarium / mimir

A backend service that provides 9c-related utility APIs.
https://nine-chronicles.dev/
GNU Affero General Public License v3.0
4 stars 22 forks source link

refactor: make return type of `BaseDiffHandler.CalculateCurrentAndTargetIndexes` understandable #482

Open moreal opened 1 week ago

moreal commented 1 week ago

Context

Currently, the return type of BaseDiffHandler.CalculateCurrentAndTargetIndexes is a tuple of four long elements, (long, long, long, long).

https://github.com/planetarium/mimir/blob/822a0c3e92d5c68c777bdc43168f589e8e668c72/Mimir.Worker/Handler/BaseDiffHandler.cs#L69

When using the method, I cannot know the role of each element without looking inside the method. I think it can be more understandable by the following ways:

Mecit-SA commented 1 day ago

Could you assign this to me, please? :)

Atralupus commented 1 day ago

Could you assign this to me, please? :)

Sure!