planetfederal / qgis-geoserver-plugin

GNU General Public License v2.0
62 stars 52 forks source link

python error (and crash) when missing or mismatching certificte (when using PKI auth) #79

Closed gioman closed 7 years ago

gioman commented 7 years ago
"An error has occurred while executing Python code: 
TypeError: sslErrors() takes exactly 3 arguments (2 given) "

How to get that:

Assume a user wants to login in Geoserver with Geoserver Explorer and wants to use PKI

It enters QGIS authentication options and adds its own authentication profile certificate

then assume that he/she forgets to import the "authority" certificates (using the "manage certificates" button) or he/she imports old ones, no more valid for the endpoint that is needed ti use

when connecting with Geoserver Explorer the user is greeted with

screenshot_20170609_114635

that i guess is expected, but when clicking on "ignore" this shows

screenshot_20170608_185008

closing this error can sometimes lead to QGIS crash.

plugin: master qgis: 2.18.9 gs: suite 4.9 (docker-compose > suite.boundless.test)

luipir commented 7 years ago

@gioman windows?

gioman commented 7 years ago

@luipir seen on windows and Linux

luipir commented 7 years ago

ha no... kde, sorry

gioman commented 7 years ago

@luipir I tested also on win

luipir commented 7 years ago

@gioman did you add also CAs (Cert authorities?)

gioman commented 7 years ago

@luipir no that's the point. If I do of course works. This is about when missing to add all them, part of them or installing no more valid ones (for example the test ones we had for "boundless-test" do not work anymore for the containers/endopoints in compose (ex: suite.boundless.test).

luipir commented 7 years ago

@gioman I agree that crash or python is not expected, my question was to narrow the way to regenerate the error

luipir commented 7 years ago

the error is generated inside geoserver plugin NetworkAccessManager method

luipir commented 7 years ago

fixed with https://github.com/boundlessgeo/qgis-geoserver-plugin/commit/b997864d29ecd492905e838e32c8026b368877f9 but travis is having problems settinup test env