plankanban / planka

The realtime kanban board for workgroups built with React and Redux.
https://planka.app
GNU Affero General Public License v3.0
8.14k stars 768 forks source link

Chart: baseURL is set including "https" if not explicitly set #894

Open kastl-ars opened 2 months ago

kastl-ars commented 2 months ago

Thanks for the nice chart, it is working (almost) perfectly!

One thing I noticed in my tests, which were done without TLS being enabled:

I could reach the planka ingress, but only got a white page. I found that the page's source code contained links to https://<hostname-from-ingress>. I could reach the site via https, but only because Traefik (my ingress controller) has a default TLS certificate.

Setting the baseURL to http://<hostname-from-ingress> allowed me to properly reach the page via HTTP.

I know this is a cornercase, but it might be worth a hint. Not sure if the baseURL can be properly derived with http or https, dependening on whether ingress.tls is set or not.

Kind Regards Johannes

kastl-ars commented 2 months ago

@Chris-Greaves FYI