planqi / slashdiablo-maphack

A customized maphack for the slashdiablo D2 server
GNU Affero General Public License v3.0
88 stars 42 forks source link

Add ItemProperties module and Monster Resistances to healthbar #7

Closed dschu012 closed 6 years ago

dschu012 commented 6 years ago

This is kind of half baked and probably requires a bit of testing around with/toggles to enable disable. But the gist of a solution for displaying the min-max values of rolls is there. 95% of the code is from https://github.com/lolet/D2Ex2/blob/master/ExScreen.cpp#L807 with offsets ported over to 1.13c

image

dschu012 commented 6 years ago

And I just saw https://github.com/planqi/slashdiablo-maphack/pull/6 😢

dschu012 commented 6 years ago

Added custom display for monster resists/missing health.

image

planqi commented 6 years ago

There is at least one issue with the variable stats display: it can hide or misrepresent a Adds 10-20 Damage type of damage modifier. So far I've seen non weapons where the stat is hidden and weapons where it displays it as +20 to maximum damage instead. That's the main reason #6 hasn't been merged yet.

Also, what's going on with BH/Constants.h and BH/D2Structs.h - was that a file/endline encoding change? I try to keep things like that as is to help other PRs. If code cleanup like that must be done, it should be in a separate PR.

I'd love to isolate the monster res display in a separate PR.