search

plasma-umass / scalene

Scalene: a high-performance, high-precision CPU, GPU, and memory profiler for Python with AI-powered optimization proposals
Apache License 2.0
12.23k stars 399 forks source link

defaults to cli #797

Closed do8tsy closed 8 months ago

do8tsy commented 8 months ago

scalene defaults to cli. in the latest version find_browser returns webbrowser.get().name. On my windows machine this is an empty string, that evaluates to False and hence web is set to false in scalene_profiler.py and cli to true. The behaviour comes from the webbrowser library and seems to be consistent over all Windows machines I had access to.

To Reproduce just run scalene insert any program

Desktop (please complete the following information):

Additional context It worked in 1.5.34

emeryberger commented 8 months ago

Thanks for the report! I've just verified that a fix for this works on Mac (as before; this affected 3.12 as well) and Windows. I'll be releasing a new version momentarily (1.5.38).

sarahec commented 8 months ago

@do8tsy my apologies -- it was my change that broke it.