platanus / potassium

A Rails application generator by Platanus, inspired by Suspenders
MIT License
232 stars 17 forks source link

Background processor is installed twice if mailer option is not none #253

Closed rjherrera closed 4 years ago

rjherrera commented 4 years ago

In the email recipe here sidekiq is added if a mailer is selected. The thing is that the background processor recipe will not prompt the user (which is correct), but it will run the install method anyway, causing sidekiq setup to be executed twice, generating warnings.

I imagine there are many approaches to solve this but we have to keep in mind that:

  1. The behavior of assuming a background processor is needed if a mailer was selected is correct and shouldn't change.
  2. Both recipes should work as codependent in every case (potassium install or potassium create).