search

platanus / potassium

A Rails application generator by Platanus, inspired by Suspenders
MIT License
232 stars 17 forks source link

chore(): use current node lts release #363

Closed gmq closed 3 years ago

rjherrera commented 3 years ago

I think there shouldn't be any problem merging this, @rjherrera could you confirm though? Wanna make sure there's nothing I'm missing, considering #366. Regardless, a couple of comments:

  • We should change the .node-version
  • Maybe we should do for potassium what it already does in the config.yml for generated projects: download the node from nodesource using potassiums .nod-version, instead of relaying in the ruby node image. We could do this in another PR, wanted to know what you guys think

You mean potassium's .node-version right? Cause the one generated for each project is done automatically using the version from version.rb. I agree with the second point, but yeah, for another one.

difernandez commented 3 years ago

You mean potassium's .node-version right?

Yes! It's currently in 12, and I think circleci/ruby:2.7.3-node uses node 14 also

rjherrera commented 3 years ago

Yes! It's currently in 12, and I think circleci/ruby:2.7.3-node uses node 14 also

Right, yeah I would upgrade that too. And now that I think of it, it should be done in this PR, because the node version ensurer uses the version from the version.rb file to check, so it should be consistent

Edit: @gmq already did it