search

platformio / platform-atmelavr

Atmel AVR: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/atmelavr
Apache License 2.0
138 stars 105 forks source link

Update board files for MightyCore compitable microcontrollers #150

Closed MCUdude closed 5 years ago

MCUdude commented 5 years ago

This will make all MightyCore compatible microcontrollers "behave" the same way as MiniCore compatible ones.

MCUdude commented 5 years ago

@ivankravets is this PR OK? Anything you'd like me to change? When this is merged, could you also upgrade MightyCore to v2.0.2?

ivankravets commented 5 years ago

Sorry, that disturb you :( I remember I asked you to make device ID in upper case. It seems that ATmega devices do not look very well in upper case. I've just checked IAR device registry -> https://www.iar.com/search-results/#!?query=&devices_architecture=AVR&devices_family=ATmega&tab=devices

Maybe, it makes sense to have the same device IDs? Could you update this PR with the same IDs?

ivankravets commented 5 years ago

When this is merged, could you also upgrade MightyCore to v2.0.2?

I did that in https://github.com/platformio/platform-atmelavr/commit/79e5ef5aa05f68f3fe3a2599251f8d5e31084c99

MCUdude commented 5 years ago

First, I did prepare the MegaCore target files in my own fork, and suddenly they have been added to this PR. That was not intended. Do you know how I remove these files from this PR?

Maybe, it makes sense to have the same device IDs? Could you update this PR with the same IDs?

So do you want me, for instance, to rename ATMEGA1284P to ATmega1284P? How about all the MiniCore targets?

ivankravets commented 5 years ago

Do you know how I remove these files from this PR?

I propose to close this PR and make a new with modified files.

So do you want me, for instance, to rename ATMEGA1284P to ATmega1284P? How about all the MiniCore targets?

Yes. I actually propose to use the same device IDs as IAR. They are a leader in this market and developers are familiar with their device naming. What do you think?

P.S: We will do the same for STM32, etc.

MCUdude commented 5 years ago

Sure! Is it OK if I do a new (giant) PR with:

ivankravets commented 5 years ago

I do a new (giant) PR with

Great! Please make a new PR.

MCUdude commented 5 years ago

You want me to change the file names as well, right?

ivankravets commented 5 years ago

Yes, fully adapt them with IAR naming policy, including previous device IDs for MightyCore.

MCUdude commented 5 years ago

Great! Meanwhile, you can add MegaCore v2.0.2 to PlatformIO if you like 🙂