search

platformio / platform-espressif8266

Espressif 8266: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/espressif8266
Apache License 2.0
323 stars 219 forks source link

Change default serial upload speed to 460k #170

Closed pfeerick closed 4 years ago

pfeerick commented 4 years ago

As of https://github.com/esp8266/Arduino/pull/5635 the esp8266/Arduino core has defaulted to 460800 baud for serial uploads and also silently limits the highest supported upload rate of 921600 to 460800.

https://github.com/esp8266/Arduino/blob/77c4f5e5cfb2286d6862621bd78120f027d10a9f/tools/upload.py#L29

sed -i "s/\"speed\"./\"speed\": 460800/g" .json

pfeerick commented 4 years ago

I did question that change in #153 but it obviously got missed ;)

ivankravets commented 4 years ago

@valeros what is default value for Arduino IDE?

valeros commented 4 years ago

Looks like It's 115200 in v2.6.1 for the most of the boards.

ascillato commented 4 years ago

Hi,

I don't recommend this change due to not all serial adapters for flashing are good enough to support that without errors. There are a bunch of low quality clones of FTDI. So, in practice, it is much better how it is now. We saw this a lot of times when helping people that are trying to flash Tasmota.

So, sorry @pfeerick I understand your point but this change will affect flashing and mainly for new users.

pfeerick commented 4 years ago

Actually, you are correct... the commit I referenced does set the default to be 460k, which has been in effect since 2.5.1.

  • Make 460K default speed, remove 961K 961K doesn't seem to work with esptool, so make 460K the default upload speed and remove 961K.

However, the boads.txt file still then overrides by putting a particular baud rate before the others in the list.

Currently, as of 2.6.1, this is

57600

921600 (making the 'Restore 921K upload opt, silent downgrade to 460k' part of that commit apply, which is still in effect now in 2.6.1, thus these boards really upload at 460800, not 921600).

115200 for all the rest.

So I'll close this PR as it will actually put this out of sync with the ESP8266 Arduino core defaults, which was it's original intent, and will review the boards files again to make sure they are all set to these values. That should make you happy too... @ascillato