search

platinasystems / go

Other
9 stars 68 forks source link

Couple of GOBGP test cases under regression are failing #161

Open sandeep-dutta opened 5 years ago

sandeep-dutta commented 5 years ago

Verified this with following goes & kernel version

root@invader29:/home/sandeep# goes version v1.2.0-rc0 root@invader29:/home/sandeep# /usr/lib/goes/vnet-platina-mk1 version fe1: v1.2.1 fe1a: v1.1.0 vnet-platina-mk1: v1.1.0-rc.1 root@invader29:/home/sandeep# root@invader29:/home/sandeep# goes buildid /usr/lib/goes/vnet-platina-mk1 Jm8PsMfgwxdNKqhWdk06/BDUbEdNqAWZcu32Ry5mh/XX4YGHztQ88mQ9hwP0ki/iAZRGQ85gHsjxXHaYbRC root@invader29:/home/sandeep# goes show buildid 4QJuEHmApoGsNyVvcgJN/OdXpmM1_5CSIb6kfZyzq/6unAnwW-cCnqwSgjKIx4/rW8Ob-Qd-wgsp6s9ipdT Kernel Version:4.13-169-gf33872c756ff

Observed that following test cases are failing to pass under regression

gobgp_bgp_peering_local_preferenc gobgp_bgp_peering_as_path gobgp_bgp_peering_if_down gobgp_bgp_convergence

The cause of the above test cases for failure is that we are not waiting for some time for the routes to get propagated & because of that during validation we are not seeing intended routes on invaders. We need to implement wait loop so that routes could be published prior to validation.

sandeep-dutta commented 5 years ago

Following test cases have been fixed.

gobgp_bgp_peering_local_preferenc gobgp_bgp_peering_as_path gobgp_bgp_peering_if_down

sandeep-dutta commented 5 years ago

gobgp_bgp_peering_administrative_distance.yml test case has also passed in recent regression runs.