fix: eslint v9 compatibility issues

LucasHill commented 1 month ago

Fixes https://github.com/platinumazure/eslint-plugin-qunit/issues/499

I verified all tests pass under eslint v9, but also maintained backward compatibility. Tests require updates that are not v8 compatible so I have another branch where I tested against v9. https://github.com/LucasHill/eslint-plugin-qunit/tree/test_fixes_for_eslint_v9

A future improvement would be to run this plugin against multiple eslint versions, as I can't include the test changes without committing to only testing on v9. If this is desired, I can bring those changes into this branch and the project will be upgraded to test against v9.

I do think it could be worth releasing this in a patch version as the changes are minimal, and intentionally backwards compatible. I know there are plans brewing for the v9 version of this library, but getting folks unblocked now would be awesome! This addon is particularly heavily used in the ember community so I'm trying to push all the eslint plugins in our ecosystem up to v9 compatibility.

Thank you!

LucasHill commented 1 month ago

@bmish thanks! pushed up those ignores and code coverage passed locally

coveralls commented 1 month ago

coverage: 100.0%. remained the same when pulling 0e006c408b3807efb27fcb887d7bbd151a4b6c39 on LucasHill:fix_eslint_v9_compat_issues into a74e161b99ad62daae363894d8a004e4a65a08a0 on platinumazure:main.

bmish commented 1 month ago

@platinumazure could you release this? Having some trouble with the release command.

bmish commented 1 month ago

I have released the new 8.1.2 version to npm, can you folks test that?

@platinumazure there are a few more steps to finish up this release, described in:

https://github.com/platinumazure/eslint-plugin-qunit/pull/533

bmish commented 1 month ago

Release completed: https://github.com/platinumazure/eslint-plugin-qunit/releases/tag/v8.1.2

platinumazure / eslint-plugin-qunit

fix: eslint v9 compatibility issues #532