search

playcanvas / editor

Issue tracker for the PlayCanvas Editor
https://playcanvas.com/
154 stars 28 forks source link

`__start__.js` is using deprecated proprerty navigator.platform #638

Open yaustar opened 2 years ago

yaustar commented 2 years ago

This should be replaced with navigator.userAgent

Forum post: https://forum.playcanvas.com/t/change-deprecated-start-js-usage/23296

willeastcott commented 1 year ago

Do we even need these hacks any more? Check out the data for iOS version market share:

https://gs.statcounter.com/ios-version-market-share/mobile-tablet/worldwide/#monthly-202301-202302-bar

I summed the iOS version usage of 12 and below and it's now 4.39% and falling. Therefore, I wouldn't be against ripping that stuff out.

yaustar commented 1 year ago

For emerging markets, this could matter more. For example, in India that number becomes 12% https://gs.statcounter.com/ios-version-market-share/mobile-tablet/india#monthly-202301-202302-bar

Some of the workarounds in the script are also not iOS 12 specific unfortunately.