playfinder / openactive

A place to submit issues with the Bookteq Openactive feeds
0 stars 0 forks source link

An idempotent (paid) B request gives different `payment` values in the response #13

Open lukehesluke opened 6 days ago

lukehesluke commented 6 days ago

For a paid activity, if a 2nd (idempotent) B request is made, it includes different fields in .payment than the 1st response

This screenshot shows an example JSON diff:

Screenshot 2024-10-17 at 14 27 39

The left hand side is the response from the 1st B request and the right hand side is the response from the 2nd B request. identifier is different in each and some fields are added/removed.

Tests that fail:

nathansalter commented 2 days ago

The additional properties and identifier should be returned in the first B response

nathansalter commented 2 days ago

We should return the additional properties for Metadata in the C2 response

nickevansuk commented 2 days ago

Broker note: additionalProperty on Payment will be available at B, and must be included within the metadata of the Stripe PaymentIntent before capture, so that payments can be correctly routed by the Booking System.

nickevansuk commented 2 days ago

When we retest this, need to ensure that additionalProperty on PaymentIntent is the same and included at both "B" and "idempotent B"