search

playframework / play-plugins

CachePlugin
444 stars 161 forks source link

Update readme.md on how to setup play 2.4.2 #158

Open ronaldwidha opened 9 years ago

ronaldwidha commented 9 years ago

The readme.md is out of date and causing specifically 2 known issues discussed in the following threads:

In summary, in Play 2.4.2, the current readme causes an exception to be thrown upon setting up @inject on JedisPool. The correct dependency is play-plugin-redis 2.4.1 (instead of 2.4.0).

Also, since all other dependencies need to participate in the dependency injection to obtain JedisPool via @Inject, I believe it is beneficial for new users to have this piece of information explicitly called out as part of the getting started step.

lightbend-cla-validator commented 9 years ago

Hi @ronaldwidha,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.typesafe.com/contribute/cla

ronaldwidha commented 9 years ago

I've signed the agreement.