playframework / play-ws

Standalone Play WS, an async HTTP client with fluent API
https://www.playframework.com/documentation/latest/JavaWS
Apache License 2.0
223 stars 85 forks source link

play-ws and play-ws-standalone conflict on play.api.libs.ws{package$, package} #185

Open gnp opened 7 years ago

gnp commented 7 years ago

Are you looking for help?

A project depending on "com.typesafe.play" %% "play-ws" % "2.6.3" brings in transitively

[info]   +-com.typesafe.play:play-ws_2.12:2.6.3 [S]
[info]   | +-com.typesafe.play:play-ws-standalone-json_2.12:1.0.4 [S]
...
[info]   | | +-com.typesafe.play:play-ws-standalone_2.12:1.0.4 [S]

which causes sbt-assembly to fail because play-ws and play-ws-standalone both define the aformentioned classes, with different contents in at least one case for the versions mentioned.

Play WS Version (2.5.x / etc)

2.6.3 / 1.0.4 (standalone)

Expected Behavior

Expected to be able to package my code using play-ws using sbt-assembly.

Actual Behavior

[error] 2 errors were encountered during merge
java.lang.RuntimeException: deduplicate: different file contents found in the following:
/root/.ivy2/cache/com.typesafe.play/play-ws_2.12/jars/play-ws_2.12-2.6.3.jar:play/api/libs/ws/package$.class
/root/.ivy2/cache/com.typesafe.play/play-ws-standalone_2.12/jars/play-ws-standalone_2.12-1.0.4.jar:play/api/libs/ws/package$.class
deduplicate: different file contents found in the following:
/root/.ivy2/cache/com.typesafe.play/play-ws_2.12/jars/play-ws_2.12-2.6.3.jar:play/api/libs/ws/package.class
/root/.ivy2/cache/com.typesafe.play/play-ws-standalone_2.12/jars/play-ws-standalone_2.12-1.0.4.jar:play/api/libs/ws/package.class
gmethvin commented 7 years ago

@gnp Does it work if you update play-ws-standalone to 1.1.0? We're planning to use that for Play 2.6.5.