search

playgameservices / cpp-android-basic-samples

Sample games using the Google Play Games C++ SDK
302 stars 131 forks source link

Minimalist example uses deprecated functionality. #4

Closed stolk closed 9 years ago

stolk commented 9 years ago

When building StateManager.cpp of the minimalistic exampe, I get:

[armeabi-v7a] Compile++ thumb: biplane <= StateManager.cpp
/home/bram/apps/Proto/Biplane/Android/jni/StateManager.cpp: In static member function 'static void StateManager::ShowAchievements()':
/home/bram/apps/Proto/Biplane/Android/jni/StateManager.cpp:99:46: warning: 'void gpg::AchievementManager::ShowAllUI()' is deprecated (declared at /home/bram/src/gpg-cpp-sdk/android/include/gpg/achievement_manager.h:297) [-Wdeprecated-declarations]
/home/bram/apps/Proto/Biplane/Android/jni/StateManager.cpp: In static member function 'static void StateManager::ShowLeaderboard(char const*)':
/home/bram/apps/Proto/Biplane/Android/jni/StateManager.cpp:106:57: warning: 'void gpg::LeaderboardManager::ShowUI(const string&)' is deprecated (declared at /home/bram/src/gpg-cpp-sdk/android/include/gpg/leaderboard_manager.h:685) [-Wdeprecated-declarations]
/home/bram/apps/Proto/Biplane/Android/jni/StateManager.cpp: In static member function 'static void StateManager::InitServices(const PlatformConfiguration&, gpg::GameServices::Builder::OnAuthActionStartedCallback, gpg::GameServices::Builder::OnAuthActionFinishedCallback)':
/home/bram/apps/Proto/Biplane/Android/jni/StateManager.cpp:120:64: warning: 'gpg::GameServices::Builder& gpg::GameServices::Builder::SetLogging(gpg::GameServices::Builder::OnLogCallback, gpg::LogLevel)' is deprecated (declared at /home/bram/src/gpg-cpp-sdk/android/include/gpg/builder.h:57) [-Wdeprecated-declarations]

This example needs to be rewritten to conform to the current API.

samtstern commented 9 years ago

That's true. If you need a correct implementation right now, check out StateManager in the new cross platform sample. Feel free to submit a PR here if you'd like to make the change.

stolk commented 9 years ago

I will switch over to the cross platform repository.